third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js - Issue 2269183003: DevTools: Merge CodeMirrorTextEditor's copyRange into text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

Issue 2269183003: DevTools: Merge CodeMirrorTextEditor's copyRange into text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

index 2b8866e2b8ce8fc7a2e11f570a820ffd954b580b..7fd36524368405e12bbf0d8879feeb2759b2cb2e 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

@@ -96,7 +96,7 @@ WebInspector.CSSSourceFrame.prototype = {

return false;

var cssUnitRange = new WebInspector.TextRange(selection.startLine, token.startColumn, selection.startLine, token.endColumn);

- var cssUnitText = this.textEditor.copyRange(cssUnitRange);

+ var cssUnitText = this.textEditor.text(cssUnitRange);

var newUnitText = this._modifyUnit(cssUnitText, change);

if (!newUnitText)

return false;

@@ -272,7 +272,7 @@ WebInspector.CSSSourceFrame.prototype = {

_cssSuggestions: function(prefixRange, substituteRange)

{

- var prefix = this._textEditor.copyRange(prefixRange);

+ var prefix = this._textEditor.text(prefixRange);

if (prefix.startsWith("$"))

return null;