Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2268893008: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, haraken, je_julie, kinuko+watch, nektarios, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). There are a few callsites with DispatchSelectEvent flag. This CL updates them so that they dispatch 'select' event themselves, and remove NeedToDispatchSelectEvent argument. Committed: https://crrev.com/ed3e774eac0889fe526f5559495e82b6167b68e5 Cr-Commit-Position: refs/heads/master@{#414622}

Patch Set 1 : Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 7 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormControlElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-26 00:53:27 UTC) #10
yosin_UTC9
lgtm Wonderful! Thanks for getting rid of a flag. (^_^)b
4 years, 3 months ago (2016-08-26 01:31:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268893008/20001
4 years, 3 months ago (2016-08-26 01:40:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-26 01:44:52 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 01:46:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed3e774eac0889fe526f5559495e82b6167b68e5
Cr-Commit-Position: refs/heads/master@{#414622}

Powered by Google App Engine
This is Rietveld 408576698