Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Issue 2268893008: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). (Closed)
Patch Set: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
index 87e6c10f871368c81beb0ae9819866fe863558a2..cb1067fa567b165c03751ed43ef0e1947d05f34d 100644
--- a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
@@ -163,7 +163,7 @@ void TextFieldInputType::setValue(const String& sanitizedValue, bool valueChange
element().updateView();
unsigned max = visibleValue().length();
- element().setSelectionRange(max, max, SelectionHasNoDirection, NotDispatchSelectEvent);
+ element().setSelectionRange(max, max);
if (!valueChanged)
return;
@@ -535,7 +535,7 @@ void TextFieldInputType::updateView()
void TextFieldInputType::focusAndSelectSpinButtonOwner()
{
element().focus();
- element().setSelectionRange(0, std::numeric_limits<int>::max(), SelectionHasNoDirection, NotDispatchSelectEvent);
+ element().setSelectionRange(0, std::numeric_limits<int>::max());
}
bool TextFieldInputType::shouldSpinButtonRespondToMouseEvents()

Powered by Google App Engine
This is Rietveld 408576698