Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange().

third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 171 matching lines @@
     setSelectionRangeForBinding(std::min(end, selectionStart()), end, selectionDirection());
 }
 
 void HTMLTextFormControlElement::setSelectionDirection(const String& direction)
 {
     setSelectionRangeForBinding(selectionStart(), selectionEnd(), direction);
 }
 
 void HTMLTextFormControlElement::select()
 {
-    setSelectionRange(0, std::numeric_limits<int>::max(), SelectionHasNoDirection, DispatchSelectEvent);
+    setSelectionRangeForBinding(0, std::numeric_limits<int>::max());
     focus();
 }
 
 bool HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(String& oldValue, String& newValue)
 {
     return !equalIgnoringNullity(oldValue, newValue);
 }
 
 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
 {
@@ skipping 50 matching lines @@
             newSelectionStart += delta;
         else if (newSelectionStart > start)
             newSelectionStart = start;
 
         if (newSelectionEnd > end)
             newSelectionEnd += delta;
         else if (newSelectionEnd > start)
             newSelectionEnd = start + replacementLength;
     }
 
-    setSelectionRange(newSelectionStart, newSelectionEnd, SelectionHasNoDirection);
+    setSelectionRangeForBinding(newSelectionStart, newSelectionEnd);
 }
 
 void HTMLTextFormControlElement::setSelectionRangeForBinding(int start, int end, const String& directionString)
 {
     TextFieldSelectionDirection direction = SelectionHasNoDirection;
     if (directionString == "forward")
         direction = SelectionHasForwardDirection;
     else if (directionString == "backward")
         direction = SelectionHasBackwardDirection;
-    setSelectionRange(start, end, direction);
+    if (setSelectionRange(start, end, direction))
+        scheduleSelectEvent();
 }
 
 static Position positionForIndex(HTMLElement* innerEditor, int index)
 {
     DCHECK_GE(index, 0);
     if (index == 0) {
         Node* node = NodeTraversal::next(*innerEditor, innerEditor);
         if (node && node->isTextNode())
             return Position(node, 0);
         return Position(innerEditor, 0);
@@ skipping 48 matching lines @@
                 index += length;
         } else if (node->hasTagName(brTag)) {
             ++index;
         }
     }
 
     DCHECK_GE(index, 0);
     return index;
 }
 
-void HTMLTextFormControlElement::setSelectionRange(int start, int end, TextFieldSelectionDirection direction, NeedToDispatchSelectEvent eventBehaviour)
+bool HTMLTextFormControlElement::setSelectionRange(int start, int end, TextFieldSelectionDirection direction)
 {
     if (openShadowRoot() || !isTextFormControl())
-        return;
+        return false;
     const int editorValueLength = static_cast<int>(innerEditorValue().length());
     DCHECK_GE(editorValueLength, 0);
     end = std::max(std::min(end, editorValueLength), 0);
     start = std::min(std::max(start, 0), end);
     LocalFrame* frame = document().frame();
     if (direction == SelectionHasNoDirection && frame && frame->editor().behavior().shouldConsiderSelectionAsDirectional())
         direction = SelectionHasForwardDirection;
     cacheSelection(start, end, direction);
 
-    if (document().focusedElement() != this) {
-        if (eventBehaviour == DispatchSelectEvent)
-            scheduleSelectEvent();
-        return;
-    }
+    if (document().focusedElement() != this)
+        return true;
 
     HTMLElement* innerEditor = innerEditorElement();
     if (!frame || !innerEditor)
-        return;
+        return true;
 
     Position startPosition = positionForIndex(innerEditor, start);
     Position endPosition = start == end ? startPosition : positionForIndex(innerEditor, end);
 
     DCHECK_EQ(start, indexForPosition(innerEditor, startPosition));
     DCHECK_EQ(end, indexForPosition(innerEditor, endPosition));
 
 #if DCHECK_IS_ON()
     // startPosition and endPosition can be null position for example when
     // "-webkit-user-select: none" style attribute is specified.
     if (startPosition.isNotNull() && endPosition.isNotNull()) {
         DCHECK_EQ(startPosition.anchorNode()->shadowHost(), this);
         DCHECK_EQ(endPosition.anchorNode()->shadowHost(), this);
     }
 #endif // DCHECK_IS_ON()
     VisibleSelection newSelection;
     if (direction == SelectionHasBackwardDirection)
         newSelection.setWithoutValidation(endPosition, startPosition);
     else
         newSelection.setWithoutValidation(startPosition, endPosition);
     newSelection.setIsDirectional(direction != SelectionHasNoDirection);
 
     frame->selection().setSelection(newSelection, FrameSelection::DoNotAdjustInFlatTree | FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotSetFocus);
-    if (eventBehaviour == DispatchSelectEvent)
-        scheduleSelectEvent();
+    return true;
 }
 
 VisiblePosition HTMLTextFormControlElement::visiblePositionForIndex(int index) const
 {
     if (index <= 0)
         return VisiblePosition::firstPositionInNode(innerEditorElement());
     Position start, end;
     bool selected = Range::selectNodeContents(innerEditorElement(), start, end);
     if (!selected)
         return VisiblePosition();
@@ skipping 162 matching lines @@
     return defaultAutocapitalize();
 }
 
 void HTMLTextFormControlElement::setAutocapitalize(const AtomicString& autocapitalize)
 {
     setAttribute(autocapitalizeAttr, autocapitalize);
 }
 
 void HTMLTextFormControlElement::restoreCachedSelection()
 {
-    setSelectionRange(m_cachedSelectionStart, m_cachedSelectionEnd, m_cachedSelectionDirection, DispatchSelectEvent);
+    if (setSelectionRange(m_cachedSelectionStart, m_cachedSelectionEnd, m_cachedSelectionDirection))
+        scheduleSelectEvent();
 }
 
 void HTMLTextFormControlElement::selectionChanged(bool userTriggered)
 {
     if (!layoutObject() || !isTextFormControl())
         return;
 
     // selectionStart() or selectionEnd() will return cached selection when this node doesn't have focus
     cacheSelection(computeSelectionStart(), computeSelectionEnd(), computeSelectionDirection());
 
@@ skipping 439 matching lines @@
 }
 
 void HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(const Element& source)
 {
     const HTMLTextFormControlElement& sourceElement = static_cast<const HTMLTextFormControlElement&>(source);
     m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit;
     HTMLFormControlElement::copyNonAttributePropertiesFromElement(source);
 }
 
 } // namespace blink