Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2268893008: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). (Closed)
Patch Set: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 973 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 } 984 }
985 985
986 void HTMLInputElement::setEditingValue(const String& value) 986 void HTMLInputElement::setEditingValue(const String& value)
987 { 987 {
988 if (!layoutObject() || !isTextField()) 988 if (!layoutObject() || !isTextField())
989 return; 989 return;
990 setInnerEditorValue(value); 990 setInnerEditorValue(value);
991 subtreeHasChanged(); 991 subtreeHasChanged();
992 992
993 unsigned max = value.length(); 993 unsigned max = value.length();
994 setSelectionRange(max, max, SelectionHasNoDirection, NotDispatchSelectEvent) ; 994 setSelectionRange(max, max);
995 dispatchInputEvent(); 995 dispatchInputEvent();
996 } 996 }
997 997
998 void HTMLInputElement::setInnerEditorValue(const String& value) 998 void HTMLInputElement::setInnerEditorValue(const String& value)
999 { 999 {
1000 HTMLTextFormControlElement::setInnerEditorValue(value); 1000 HTMLTextFormControlElement::setInnerEditorValue(value);
1001 m_needsToUpdateViewValue = false; 1001 m_needsToUpdateViewValue = false;
1002 } 1002 }
1003 1003
1004 void HTMLInputElement::setValue(const String& value, ExceptionState& exceptionSt ate, TextFieldEventBehavior eventBehavior) 1004 void HTMLInputElement::setValue(const String& value, ExceptionState& exceptionSt ate, TextFieldEventBehavior eventBehavior)
(...skipping 903 matching lines...) Expand 10 before | Expand all | Expand 10 after
1908 { 1908 {
1909 return m_inputTypeView->hasFallbackContent(); 1909 return m_inputTypeView->hasFallbackContent();
1910 } 1910 }
1911 1911
1912 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths) 1912 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths)
1913 { 1913 {
1914 return m_inputType->setFilesFromPaths(paths); 1914 return m_inputType->setFilesFromPaths(paths);
1915 } 1915 }
1916 1916
1917 } // namespace blink 1917 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698