ash: Remove unnecessary WmShelf::SchedulePaint() method

ash: Remove unnecessary WmShelf::SchedulePaint() method

This method existed because the overflow bubble used it to cause a repaint of
the overflow button in the parent shelf view. Instead of repainting all the
buttons, just repaint the anchor directly.

(I am uncertain this code path ever gets called in production. It would only
run if some code directly destroyed the bubble widget instead of calling into
the shelf code to do so. This does not seem to happen at shutdown or when
disconnecting a display, even with the bubble visible. However, failure to
cleanup the cached pointers in OverflowBubble on widget destruction would
cause crashes, so I'm keeping the OnWidgetDestroying() method.)

BUG=615502
TEST=ash_browsertests, manual tests of opening and closing the overflow bubble
on multiple displays

Committed: https://crrev.com/44f141a103fe98f7c1be86ab8dfe80ce49204ca5
Cr-Commit-Position: refs/heads/master@{#413556}

[James Cook, 2016-08-22 21:32:23]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:34:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-22 21:35:58]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-22 21:35:58]

msw, please take a look.

I dug into the history of OverflowBubble::OnWidgetDestroying() and wasn't able
to find anything useful. The method was added here without comment:

https://chromiumcodereview.appspot.com/10659003/diff/10010/ash/launcher/overf...

The repaint was added here:

https://chromiumcodereview.appspot.com/22527003/diff/47001/ash/launcher/overf...

As I mentioned in the CL description, I'm not sure OnWidgetDestroying() is
needed at all, but I'm keeping it for safety, and since the intent of the
repaint seems to be to repaint the anchor, it's simple to keep that.

[msw, 2016-08-22 21:48:25]

lgtm

https://codereview.chromium.org/2267803003/diff/1/ash/common/shelf/overflow_b...
File ash/common/shelf/overflow_bubble.cc (right):

https://codereview.chromium.org/2267803003/diff/1/ash/common/shelf/overflow_b...
ash/common/shelf/overflow_bubble.cc:31: void OverflowBubble::Show(views::View*
anchor, ShelfView* shelf_view) {
aside: it'd be nice to merge OverflowBubble and OverflowBubbleView.

https://codereview.chromium.org/2267803003/diff/1/ash/common/shelf/overflow_b...
ash/common/shelf/overflow_bubble.cc:88: // Update the overflow button in the
parent ShelfView.
Hmm, it's hard to tell if this will be called after
ShelfView::IsShowingOverflowBubble() would return false, but I presume the
scheduling posts a task or similar, so this should be okay.

[James Cook, 2016-08-22 21:56:29]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-08-22 21:56:35]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:36:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:36:38]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-08-22 22:38:06]

Description was changed from

==========
ash: Remove unnecessary WmShelf::SchedulePaint() method

This method existed because the overflow bubble used it to cause a repaint of
the overflow button in the parent shelf view. Instead of repainting all the
buttons, just repaint the anchor directly.

(I am uncertain this code path ever gets called in production. It would only
run if some code directly destroyed the bubble widget instead of calling into
the shelf code to do so. This does not seem to happen at shutdown or when
disconnecting a display, even with the bubble visible. However, failure to
cleanup the cached pointers in OverflowBubble on widget destruction would
cause crashes, so I'm keeping the OnWidgetDestroying() method.)

BUG=615502
TEST=ash_browsertests, manual tests of opening and closing the overflow bubble
on multiple displays
==========

to

==========
ash: Remove unnecessary WmShelf::SchedulePaint() method

This method existed because the overflow bubble used it to cause a repaint of
the overflow button in the parent shelf view. Instead of repainting all the
buttons, just repaint the anchor directly.

(I am uncertain this code path ever gets called in production. It would only
run if some code directly destroyed the bubble widget instead of calling into
the shelf code to do so. This does not seem to happen at shutdown or when
disconnecting a display, even with the bubble visible. However, failure to
cleanup the cached pointers in OverflowBubble on widget destruction would
cause crashes, so I'm keeping the OnWidgetDestroying() method.)

BUG=615502
TEST=ash_browsertests, manual tests of opening and closing the overflow bubble
on multiple displays

Committed: https://crrev.com/44f141a103fe98f7c1be86ab8dfe80ce49204ca5
Cr-Commit-Position: refs/heads/master@{#413556}
==========

[commit-bot: I haz the power, 2016-08-22 22:38:08]

Patchset 1 (id:??) landed as
https://crrev.com/44f141a103fe98f7c1be86ab8dfe80ce49204ca5
Cr-Commit-Position: refs/heads/master@{#413556}