Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: ash/common/shelf/wm_shelf.h

Issue 2267803003: ash: Remove unnecessary WmShelf::SchedulePaint() method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_SHELF_WM_SHELF_H_ 5 #ifndef ASH_COMMON_SHELF_WM_SHELF_H_
6 #define ASH_COMMON_SHELF_WM_SHELF_H_ 6 #define ASH_COMMON_SHELF_WM_SHELF_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "ash/common/shelf/shelf_types.h" 9 #include "ash/common/shelf/shelf_types.h"
10 #include "ash/shelf/shelf_layout_manager_observer.h" 10 #include "ash/shelf/shelf_layout_manager_observer.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 // widget. Returns null if shelf dimming is not supported (e.g. on mus). 71 // widget. Returns null if shelf dimming is not supported (e.g. on mus).
72 // TODO(jamescook): Delete this after material design ships, as MD will not 72 // TODO(jamescook): Delete this after material design ships, as MD will not
73 // require shelf dimming. http://crbug.com/614453 73 // require shelf dimming. http://crbug.com/614453
74 virtual WmDimmerView* CreateDimmerView(bool disable_animations_for_test); 74 virtual WmDimmerView* CreateDimmerView(bool disable_animations_for_test);
75 75
76 // Shelf items are slightly dimmed (e.g. when a window is maximized). 76 // Shelf items are slightly dimmed (e.g. when a window is maximized).
77 // TODO(jamescook): Delete this after material design ships, as MD will not 77 // TODO(jamescook): Delete this after material design ships, as MD will not
78 // require shelf dimming. http://crbug.com/614453 78 // require shelf dimming. http://crbug.com/614453
79 bool IsDimmed() const; 79 bool IsDimmed() const;
80 80
81 // Schedules a repaint for all shelf buttons.
82 // TODO(jamescook): Eliminate when ShelfView moves to //ash/common.
83 // http://crbug.com/615155
84 void SchedulePaint();
85
86 // Whether the shelf view is visible. 81 // Whether the shelf view is visible.
87 // TODO(jamescook): Consolidate this with GetVisibilityState(). 82 // TODO(jamescook): Consolidate this with GetVisibilityState().
88 bool IsVisible() const; 83 bool IsVisible() const;
89 84
90 void UpdateVisibilityState(); 85 void UpdateVisibilityState();
91 86
92 ShelfVisibilityState GetVisibilityState() const; 87 ShelfVisibilityState GetVisibilityState() const;
93 88
94 // Returns the ideal bounds of the shelf assuming it is visible. 89 // Returns the ideal bounds of the shelf assuming it is visible.
95 gfx::Rect GetIdealBounds(); 90 gfx::Rect GetIdealBounds();
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 ShelfLayoutManager* shelf_layout_manager_ = nullptr; 134 ShelfLayoutManager* shelf_layout_manager_ = nullptr;
140 135
141 base::ObserverList<WmShelfObserver> observers_; 136 base::ObserverList<WmShelfObserver> observers_;
142 137
143 DISALLOW_COPY_AND_ASSIGN(WmShelf); 138 DISALLOW_COPY_AND_ASSIGN(WmShelf);
144 }; 139 };
145 140
146 } // namespace ash 141 } // namespace ash
147 142
148 #endif // ASH_COMMON_SHELF_WM_SHELF_H_ 143 #endif // ASH_COMMON_SHELF_WM_SHELF_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698