ash: Remove unnecessary WmShelf::SchedulePaint() method

ash/common/shelf/overflow_bubble.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/shelf/overflow_bubble.h"
 
 #include "ash/common/shelf/overflow_bubble_view.h"
 #include "ash/common/shelf/shelf_view.h"
 #include "ash/common/shelf/wm_shelf.h"
 #include "ash/common/system/tray/tray_background_view.h"
@@ skipping 10 matching lines @@
       shelf_view_(nullptr) {
   const bool wants_moves = false;
   WmShell::Get()->AddPointerWatcher(this, wants_moves);
 }
 
 OverflowBubble::~OverflowBubble() {
   Hide();
   WmShell::Get()->RemovePointerWatcher(this);
 }
 
 void OverflowBubble::Show(views::View* anchor, ShelfView* shelf_view) {

[msw, 2016/08/22 21:48:25]

aside: it'd be nice to merge OverflowBubble and OverflowBubbleView.

+  DCHECK(anchor);
+  DCHECK(shelf_view);
+
   Hide();
 
   bubble_ = new OverflowBubbleView(wm_shelf_);
   bubble_->InitOverflowBubble(anchor, shelf_view);
   shelf_view_ = shelf_view;
   anchor_ = anchor;
 
   TrayBackgroundView::InitializeBubbleAnimations(bubble_->GetWidget());
   bubble_->GetWidget()->AddObserver(this);
   bubble_->GetWidget()->Show();
@@ skipping 33 matching lines @@
 void OverflowBubble::OnPointerEventObserved(
     const ui::PointerEvent& event,
     const gfx::Point& location_in_screen,
     views::Widget* target) {
   if (event.type() == ui::ET_POINTER_DOWN)
     ProcessPressedEvent(location_in_screen);
 }
 
 void OverflowBubble::OnWidgetDestroying(views::Widget* widget) {
   DCHECK(widget == bubble_->GetWidget());
-  bubble_ = NULL;
-  anchor_ = NULL;
-  wm_shelf_->SchedulePaint();
-  shelf_view_ = NULL;
+  // Update the overflow button in the parent ShelfView.

[msw, 2016/08/22 21:48:25]

Hmm, it's hard to tell if this will be called after
ShelfView::IsShowingOverflowBubble() would return false, but I presume the
scheduling posts a task or similar, so this should be okay.

+  anchor_->SchedulePaint();
+  bubble_ = nullptr;
+  anchor_ = nullptr;
+  shelf_view_ = nullptr;
 }
 
 }  // namespace ash