Chromium Code Reviews| Index: ash/common/shelf/overflow_bubble.cc |
| diff --git a/ash/common/shelf/overflow_bubble.cc b/ash/common/shelf/overflow_bubble.cc |
| index b0ae2bc69386caf052e56c8a19b95c25e1fe8051..fccafd0496dfa5e88b841da3fb0a65053a125c15 100644 |
| --- a/ash/common/shelf/overflow_bubble.cc |
| +++ b/ash/common/shelf/overflow_bubble.cc |
| @@ -29,6 +29,9 @@ OverflowBubble::~OverflowBubble() { |
| } |
| void OverflowBubble::Show(views::View* anchor, ShelfView* shelf_view) { |
|
msw
2016/08/22 21:48:25
aside: it'd be nice to merge OverflowBubble and Ov
|
| + DCHECK(anchor); |
| + DCHECK(shelf_view); |
| + |
| Hide(); |
| bubble_ = new OverflowBubbleView(wm_shelf_); |
| @@ -82,10 +85,11 @@ void OverflowBubble::OnPointerEventObserved( |
| void OverflowBubble::OnWidgetDestroying(views::Widget* widget) { |
| DCHECK(widget == bubble_->GetWidget()); |
| - bubble_ = NULL; |
| - anchor_ = NULL; |
| - wm_shelf_->SchedulePaint(); |
| - shelf_view_ = NULL; |
| + // Update the overflow button in the parent ShelfView. |
|
msw
2016/08/22 21:48:25
Hmm, it's hard to tell if this will be called afte
|
| + anchor_->SchedulePaint(); |
| + bubble_ = nullptr; |
| + anchor_ = nullptr; |
| + shelf_view_ = nullptr; |
| } |
| } // namespace ash |