Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant IsEmpty checks after calling toV8() toV8() never returns an empty handle. We don't need to check IsEmpty. BUG=625512

Patch Set 1 #

Total comments: 3

Patch Set 2 : temp #

Patch Set 3 : temp #

Patch Set 4 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -98 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Iterable.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 14 chunks +9 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp View 1 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp View 1 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-24 11:24:14 UTC) #2
Yuki
https://codereview.chromium.org/2267403006/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp File third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp (right): https://codereview.chromium.org/2267403006/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp#newcode101 third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp:101: if (!wrappedEvent->IsObject()) Unless |event| is not nullptr, toV8() must ...
4 years, 4 months ago (2016-08-24 12:02:08 UTC) #3
Yuki
LGTM.
4 years, 4 months ago (2016-08-24 12:02:48 UTC) #4
haraken
On 2016/08/24 12:02:08, Yuki wrote: > https://codereview.chromium.org/2267403006/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp > File third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp (right): > > https://codereview.chromium.org/2267403006/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp#newcode101 > ...
4 years, 4 months ago (2016-08-25 01:28:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267403006/20001
4 years, 4 months ago (2016-08-25 01:29:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/189258)
4 years, 4 months ago (2016-08-25 01:43:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267403006/40001
4 years, 4 months ago (2016-08-25 01:50:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/189276) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-25 02:08:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267403006/60001
4 years, 4 months ago (2016-08-25 02:31:09 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/284391)
4 years, 4 months ago (2016-08-25 03:44:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267403006/60001
4 years, 4 months ago (2016-08-25 03:51:58 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/284427)
4 years, 4 months ago (2016-08-25 05:07:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267403006/60001
4 years, 3 months ago (2016-09-05 00:32:34 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 01:27:55 UTC) #28
Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698