third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

index d1eadaa3a78e96b021e5daef3163c10b70edc263..a4f4c43b5001522c9c7af514e64f30346442c01c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

@@ -93,12 +93,6 @@ unsigned V8NodeFilterCondition::acceptNode(Node* node, ExceptionState& exception

}

v8::Local<v8::Value> nodeWrapper = toV8(node, m_scriptState.get());

- if (nodeWrapper.IsEmpty()) {

- if (exceptionCatcher.HasCaught())

- exceptionState.rethrowV8Exception(exceptionCatcher.Exception());

- return NodeFilter::kFilterReject;

- }

v8::Local<v8::Value> result;

v8::Local<v8::Value> args[] = { nodeWrapper };

if (!V8ScriptRunner::callFunction(callback, m_scriptState->getExecutionContext(), receiver, 1, args, isolate).ToLocal(&result)) {