third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

index 5da2531c04194e3130988a59123366b9d76b9e1f..61e07bbe4806a6cf040df58d655a9e23cabd589d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -90,8 +90,6 @@ void V8AbstractEventListener::handleEvent(ScriptState* scriptState, Event* event

// Get the V8 wrapper for the event object.

v8::Local<v8::Value> jsEvent = toV8(event, scriptState->context()->Global(), isolate());

- if (jsEvent.IsEmpty())

- return;

invokeEventHandler(scriptState, event, v8::Local<v8::Value>::New(isolate(), jsEvent));

}

@@ -173,8 +171,6 @@ v8::Local<v8::Object> V8AbstractEventListener::getReceiverObject(ScriptState* sc

EventTarget* target = event->currentTarget();

v8::Local<v8::Value> value = toV8(target, scriptState->context()->Global(), isolate());

- if (value.IsEmpty())

- return v8::Local<v8::Object>();

return v8::Local<v8::Object>::New(isolate(), v8::Local<v8::Object>::Cast(value));

}