third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

index fa81e2e12f2c46e21badf8b16895d60e4e598abf..3de1fbc39ba77cd288e31f14ab999e24abd5b311 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

@@ -103,9 +103,6 @@ NodeFilter* toNodeFilter(v8::Local<v8::Value> callback, v8::Local<v8::Object> cr

NodeFilter* filter = NodeFilter::create();

v8::Local<v8::Value> filterWrapper = toV8(filter, creationContext, scriptState->isolate());

- if (filterWrapper.IsEmpty())

- return nullptr;

NodeFilterCondition* condition = V8NodeFilterCondition::create(callback, filterWrapper.As<v8::Object>(), scriptState);

filter->setCondition(condition);