Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2265013003: win: Move NTDDI_VERSION into winver, stop setting it for usrsctp (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, grt (UTC plus 2)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Move NTDDI_VERSION into winver, stop setting it for usrsctp If people want to change WINVER, they likely want to change NTDDI_VERSION as well, so it make sense to have both in the same config. The one other use of :winver, usrsctp, didn't change NTDDI_VERSION, but it looks like it doesn't need to change WINVER anymore anyhow (it did that for XP support), so drop it there. No intended behavior change. BUG=639853 Committed: https://crrev.com/1768309c444850128578325a51afb21599cdcd21 Cr-Commit-Position: refs/heads/master@{#413480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M build/config/win/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/usrsctp/BUILD.gn View 1 chunk +1 line, -10 lines 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
4 years, 3 months ago (2016-08-22 16:34:59 UTC) #3
scottmg
lgtm
4 years, 3 months ago (2016-08-22 17:10:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265013003/1
4 years, 3 months ago (2016-08-22 17:16:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-22 18:38:34 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-22 18:42:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1768309c444850128578325a51afb21599cdcd21
Cr-Commit-Position: refs/heads/master@{#413480}

Powered by Google App Engine
This is Rietveld 408576698