Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/usrsctp/BUILD.gn

Issue 2265013003: win: Move NTDDI_VERSION into winver, stop setting it for usrsctp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/win/BUILD.gn ('k') | third_party/usrsctp/usrsctp.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/usrsctp/BUILD.gn
diff --git a/third_party/usrsctp/BUILD.gn b/third_party/usrsctp/BUILD.gn
index 4662796376561165d021ecf64297e9a3652a2805..7e65a69cef48d3c4ad3ae0c50b47ab50dacd61cc 100644
--- a/third_party/usrsctp/BUILD.gn
+++ b/third_party/usrsctp/BUILD.gn
@@ -123,16 +123,7 @@ static_library("usrsctp") {
}
if (is_win) {
- defines += [
- "__Userspace_os_Windows",
-
- # Manually setting WINVER and _WIN32_WINNT is needed because Chrome
- # sets WINVER to a newer version of windows. But compiling usrsctp
- # this way would is incompatible with windows XP.
- "WINVER=0x0502",
- "_WIN32_WINNT=0x0502",
- ]
- configs -= [ "//build/config/win:winver" ]
+ defines += [ "__Userspace_os_Windows" ]
} else {
defines += [ "NON_WINDOWS_DEFINE" ]
}
« no previous file with comments | « build/config/win/BUILD.gn ('k') | third_party/usrsctp/usrsctp.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698