Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/usrsctp/usrsctp.gyp

Issue 2265013003: win: Move NTDDI_VERSION into winver, stop setting it for usrsctp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/usrsctp/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/usrsctp/usrsctp.gyp
diff --git a/third_party/usrsctp/usrsctp.gyp b/third_party/usrsctp/usrsctp.gyp
index 9533fb8ed12e0b0c8e7c71a76280a421cbbdd032..cfae0487df0d9a2a23839e01ac9979effb0191f9 100644
--- a/third_party/usrsctp/usrsctp.gyp
+++ b/third_party/usrsctp/usrsctp.gyp
@@ -106,7 +106,7 @@
['OS=="linux" or OS=="android"', {
'defines': [
'__Userspace_os_Linux',
- '_GNU_SOURCE'
+ '_GNU_SOURCE'
],
'cflags!': [ '-Werror', '-Wall' ],
'cflags': [ '-w' ],
@@ -130,16 +130,6 @@
['OS=="win"', {
'defines': [
'__Userspace_os_Windows',
- # Manually setting WINVER and _WIN32_WINNT is needed because Chrome
- # sets WINVER to a newer version of Windows. But compiling usrsctp
- # this way would be incompatible with Windows XP.
- 'WINVER=0x0502',
- '_WIN32_WINNT=0x0502',
- ],
- 'defines!': [
- # Remove Chrome's WINVER defines to avoid redefinition warnings.
- 'WINVER=0x0A00',
- '_WIN32_WINNT=0x0A00',
],
'cflags!': [ '/W3', '/WX' ],
'cflags': [ '/w' ],
« no previous file with comments | « third_party/usrsctp/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698