Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: third_party/usrsctp/usrsctp.gyp

Issue 2265013003: win: Move NTDDI_VERSION into winver, stop setting it for usrsctp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/usrsctp/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'libsctp_target_type%': 'static_library', 6 'libsctp_target_type%': 'static_library',
7 }, 7 },
8 'target_defaults': { 8 'target_defaults': {
9 'defines': [ 9 'defines': [
10 'SCTP_PROCESS_LEVEL_LOCKS', 10 'SCTP_PROCESS_LEVEL_LOCKS',
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 'variables': { 99 'variables': {
100 'clang_warning_flags': [ 100 'clang_warning_flags': [
101 # atomic_init in user_atomic.h is a static function in a header. 101 # atomic_init in user_atomic.h is a static function in a header.
102 '-Wno-unused-function', 102 '-Wno-unused-function',
103 ], 103 ],
104 }, 104 },
105 'conditions': [ 105 'conditions': [
106 ['OS=="linux" or OS=="android"', { 106 ['OS=="linux" or OS=="android"', {
107 'defines': [ 107 'defines': [
108 '__Userspace_os_Linux', 108 '__Userspace_os_Linux',
109 » '_GNU_SOURCE' 109 '_GNU_SOURCE'
110 ], 110 ],
111 'cflags!': [ '-Werror', '-Wall' ], 111 'cflags!': [ '-Werror', '-Wall' ],
112 'cflags': [ '-w' ], 112 'cflags': [ '-w' ],
113 }], 113 }],
114 ['OS=="mac" or OS=="ios"', { 114 ['OS=="mac" or OS=="ios"', {
115 'defines': [ 115 'defines': [
116 'HAVE_SA_LEN', 116 'HAVE_SA_LEN',
117 'HAVE_SCONN_LEN', 117 'HAVE_SCONN_LEN',
118 '__APPLE_USE_RFC_2292', 118 '__APPLE_USE_RFC_2292',
119 '__Userspace_os_Darwin', 119 '__Userspace_os_Darwin',
120 ], 120 ],
121 # usrsctp requires that __APPLE__ is undefined for compilation (for 121 # usrsctp requires that __APPLE__ is undefined for compilation (for
122 # historical reasons). There is a plan to change this, and when it 122 # historical reasons). There is a plan to change this, and when it
123 # happens and we re-roll DEPS for usrsctp, we can remove the manual 123 # happens and we re-roll DEPS for usrsctp, we can remove the manual
124 # undefining of __APPLE__. 124 # undefining of __APPLE__.
125 'xcode_settings': { 125 'xcode_settings': {
126 'OTHER_CFLAGS!': [ '-Werror', '-Wall' ], 126 'OTHER_CFLAGS!': [ '-Werror', '-Wall' ],
127 'OTHER_CFLAGS': [ '-U__APPLE__', '-w' ], 127 'OTHER_CFLAGS': [ '-U__APPLE__', '-w' ],
128 }, 128 },
129 }], 129 }],
130 ['OS=="win"', { 130 ['OS=="win"', {
131 'defines': [ 131 'defines': [
132 '__Userspace_os_Windows', 132 '__Userspace_os_Windows',
133 # Manually setting WINVER and _WIN32_WINNT is needed because Chrome
134 # sets WINVER to a newer version of Windows. But compiling usrsctp
135 # this way would be incompatible with Windows XP.
136 'WINVER=0x0502',
137 '_WIN32_WINNT=0x0502',
138 ],
139 'defines!': [
140 # Remove Chrome's WINVER defines to avoid redefinition warnings.
141 'WINVER=0x0A00',
142 '_WIN32_WINNT=0x0A00',
143 ], 133 ],
144 'cflags!': [ '/W3', '/WX' ], 134 'cflags!': [ '/W3', '/WX' ],
145 'cflags': [ '/w' ], 135 'cflags': [ '/w' ],
146 # TODO(ldixon) : Remove this disabling of warnings by pushing a 136 # TODO(ldixon) : Remove this disabling of warnings by pushing a
147 # fix upstream to usrsctp 137 # fix upstream to usrsctp
148 'msvs_disabled_warnings': [ 4002, 4013, 4133, 4267, 4313, 4700 ], 138 'msvs_disabled_warnings': [ 4002, 4013, 4133, 4267, 4313, 4700 ],
149 }, { # OS != "win", 139 }, { # OS != "win",
150 'defines': [ 140 'defines': [
151 'NON_WINDOWS_DEFINE', 141 'NON_WINDOWS_DEFINE',
152 ], 142 ],
153 }], 143 }],
154 ], # conditions 144 ], # conditions
155 }, # target usrsctp 145 }, # target usrsctp
156 ], # targets 146 ], # targets
157 } 147 }
OLDNEW
« no previous file with comments | « third_party/usrsctp/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698