DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional.

DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional.

BUG=635947
Committed: https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae
Cr-Commit-Position: refs/heads/master@{#413580}

[alph, 2016-08-22 19:05:42]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org

[caseq, 2016-08-22 19:14:19]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-08-22 19:14:20]

lgtm % nits

https://codereview.chromium.org/2262303002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
(right):

https://codereview.chromium.org/2262303002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp:34:
std::unique_ptr<protocol::Array<protocol::Profiler::PositionTickInfo>> array =
protocol::Array<protocol::Profiler::PositionTickInfo>::create();
auto array = ...

https://codereview.chromium.org/2262303002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp:71: if
(deoptReason && deoptReason[0] != '\0' && strcmp(deoptReason, "no reason"))
nit: drop != '\0'

[alph, 2016-08-22 19:24:08]

thanks

https://codereview.chromium.org/2262303002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
(right):

https://codereview.chromium.org/2262303002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp:34:
std::unique_ptr<protocol::Array<protocol::Profiler::PositionTickInfo>> array =
protocol::Array<protocol::Profiler::PositionTickInfo>::create();
On 2016/08/22 19:14:20, caseq wrote:
> auto array = ...

Done.

https://codereview.chromium.org/2262303002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp:71: if
(deoptReason && deoptReason[0] != '\0' && strcmp(deoptReason, "no reason"))
On 2016/08/22 19:14:20, caseq wrote:
> nit: drop != '\0'

Done.

[alph, 2016-08-22 21:04:12]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:06:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:49:57]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-08-22 23:24:43]

lgtm

[alph, 2016-08-22 23:25:08]

The CQ bit was checked by alph@chromium.org

[alph, 2016-08-22 23:25:08]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2262303002/#ps20001
(title: "addressing caseq comments")

[commit-bot: I haz the power, 2016-08-22 23:25:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:31:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 23:33:22]

Description was changed from

==========
DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields
optional.

BUG=635947
==========

to

==========
DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields
optional.

BUG=635947

Committed: https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae
Cr-Commit-Position: refs/heads/master@{#413580}
==========

[commit-bot: I haz the power, 2016-08-22 23:33:23]

Patchset 2 (id:??) landed as
https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae
Cr-Commit-Position: refs/heads/master@{#413580}