third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing caseq comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index 876e4e32a0dc27028c98458cb52c4eb3a2d2b765..a5b9e614a0d2ad0e910085d90bc7ffb88332294b 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -702,11 +702,8 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve

if (event.warning)

contentHelper.appendWarningRow(event);

- if (event.name === recordTypes.JSFrame) {

- var deoptReason = eventData["deoptReason"];

- if (deoptReason && deoptReason !== "no reason")

- contentHelper.appendWarningRow(event, WebInspector.TimelineModel.WarningType.V8Deopt);

- }

+ if (event.name === recordTypes.JSFrame && eventData["deoptReason"])

+ contentHelper.appendWarningRow(event, WebInspector.TimelineModel.WarningType.V8Deopt);

if (detailed) {

contentHelper.appendTextRow(WebInspector.UIString("Self Time"), Number.millisToString(event.selfTime, true));