third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js - Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing caseq comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

index 0ad215db5d3d430599e4778fbab8c0df75ae3736..fd0bf750494b40baa2a0795c095c549683692fce 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

@@ -45,7 +45,7 @@ WebInspector.ProfileDataGridNode = function(profileNode, owningTree, hasChildren

this.self = profileNode.self;

this.total = profileNode.total;

this.functionName = WebInspector.beautifyFunctionName(profileNode.functionName);

- this._deoptReason = profileNode.deoptReason && profileNode.deoptReason !== "no reason" ? profileNode.deoptReason : "";

+ this._deoptReason = profileNode.deoptReason || "";

this.url = profileNode.url;

}