third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js - Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing caseq comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

index 4798bad68855f5daa1a25853763f5e8ccd833d4c..946e5c3270ec19c947ee53431746713b90738511 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

@@ -178,8 +178,7 @@ WebInspector.ProfileFlameChartDataProvider.prototype = {

this._boldFont = "bold " + this._font;

}

var node = this._entryNodes[entryIndex];

- var reason = node.deoptReason;

- return (reason && reason !== "no reason") ? this._boldFont : this._font;

+ return node.deoptReason ? this._boldFont : this._font;

/**

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js » ('j') | no next file with comments »