Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2260203004: Create StubCredentialsFilter (Closed)

Created:
4 years, 4 months ago by vabr (Chromium)
Modified:
4 years, 4 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@621355_best_matches_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create StubCredentialsFilter Currently, there are three independent testing implementations of the CredentialsFilter API, all providing similar no-op implementation. In a coming CL there will be a fourth one. This CL pulls the stub of the API into a separate file, simplifying the 3 (soon 4) places in code where it is needed. BUG=621355 Committed: https://crrev.com/0cc50262a056391589a3a09515cbe67b9ebbe157 Cr-Commit-Position: refs/heads/master@{#413455}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Just rebased #

Patch Set 4 : Just rebased #

Patch Set 5 : Rebased to avoid dependency #

Messages

Total messages: 22 (16 generated)
vabr (Chromium)
Hi Vasilii, Could you PTAL? This CL is currently blocked by a bigger one, so ...
4 years, 4 months ago (2016-08-22 14:52:11 UTC) #14
vasilii
lgtm
4 years, 4 months ago (2016-08-22 15:03:42 UTC) #15
vabr (Chromium)
Thanks, you are super-fast, Vasilii! I rebased the CL off origin/master to avoid the dependency ...
4 years, 4 months ago (2016-08-22 15:20:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260203004/80001
4 years, 4 months ago (2016-08-22 15:20:49 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-22 16:39:55 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:41:51 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0cc50262a056391589a3a09515cbe67b9ebbe157
Cr-Commit-Position: refs/heads/master@{#413455}

Powered by Google App Engine
This is Rietveld 408576698