Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.h

Issue 2260203004: Create StubCredentialsFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_best_matches_const
Patch Set: Rebased to avoid dependency Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/stub_password_manager_client.h
diff --git a/components/password_manager/core/browser/stub_password_manager_client.h b/components/password_manager/core/browser/stub_password_manager_client.h
index de8e1f9a66ce35ae898d17186fc36b7a1d97f00f..be0ef050cf789177684f5c879750574282447c25 100644
--- a/components/password_manager/core/browser/stub_password_manager_client.h
+++ b/components/password_manager/core/browser/stub_password_manager_client.h
@@ -7,6 +7,7 @@
#include "base/macros.h"
#include "components/password_manager/core/browser/password_manager_client.h"
+#include "components/password_manager/core/browser/stub_credentials_filter.h"
#include "components/password_manager/core/browser/stub_log_manager.h"
namespace password_manager {
@@ -45,20 +46,7 @@ class StubPasswordManagerClient : public PasswordManagerClient {
const LogManager* GetLogManager() const override;
private:
- // This filter does not filter out anything, it is a dummy implementation of
- // the filter interface.
- class PassThroughCredentialsFilter : public CredentialsFilter {
- public:
- PassThroughCredentialsFilter() {}
-
- // CredentialsFilter:
- std::vector<std::unique_ptr<autofill::PasswordForm>> FilterResults(
- std::vector<std::unique_ptr<autofill::PasswordForm>> results)
- const override;
- bool ShouldSave(const autofill::PasswordForm& form) const override;
- };
-
- const PassThroughCredentialsFilter credentials_filter_;
+ const StubCredentialsFilter credentials_filter_;
StubLogManager log_manager_;
DISALLOW_COPY_AND_ASSIGN(StubPasswordManagerClient);

Powered by Google App Engine
This is Rietveld 408576698