Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 2260203004: Create StubCredentialsFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_best_matches_const
Patch Set: Rebased to avoid dependency Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc
index d20a9974dbedbfc30150969ae2dc2247f14b7635..d1143bdeb6f6c472a3a8b66acc6eb0221ddb9dfb 100644
--- a/components/password_manager/core/browser/password_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_unittest.cc
@@ -20,6 +20,7 @@
#include "components/password_manager/core/browser/password_manager_driver.h"
#include "components/password_manager/core/browser/password_store.h"
#include "components/password_manager/core/browser/statistics_table.h"
+#include "components/password_manager/core/browser/stub_credentials_filter.h"
#include "components/password_manager/core/browser/stub_password_manager_client.h"
#include "components/password_manager/core/browser/stub_password_manager_driver.h"
#include "components/password_manager/core/common/password_manager_features.h"
@@ -39,20 +40,11 @@ namespace password_manager {
namespace {
-class MockStoreResultFilter : public CredentialsFilter {
+class MockStoreResultFilter : public StubCredentialsFilter {
public:
- MOCK_CONST_METHOD1(FilterResultsPtr,
- void(std::vector<std::unique_ptr<PasswordForm>>* results));
MOCK_CONST_METHOD1(ShouldSave, bool(const autofill::PasswordForm& form));
MOCK_CONST_METHOD1(ReportFormLoginSuccess,
void(const PasswordFormManager& form_manager));
-
- // GMock cannot handle move-only arguments.
- std::vector<std::unique_ptr<PasswordForm>> FilterResults(
- std::vector<std::unique_ptr<PasswordForm>> results) const override {
- FilterResultsPtr(&results);
- return results;
- }
};
class MockPasswordManagerClient : public StubPasswordManagerClient {

Powered by Google App Engine
This is Rietveld 408576698