Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2258563003: Added features to BlimpClientContext and BlimpContents (Closed)

Created:
4 years, 4 months ago by shaktisahu
Modified:
4 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ime_feature_move
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added features to BlimpClientContext and BlimpContents This CL instantiates ImeFeature and NavigationFeature inside BlimpClientContext. BlimpClientContext owns these features and passes raw pointers to BlimpContents during construction. BUG=611111 Committed: https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f Cr-Commit-Position: refs/heads/master@{#414786}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Register features #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -27 lines) Patch
M blimp/client/core/blimp_client_context_impl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M blimp/client/core/blimp_client_context_impl.cc View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_impl.h View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M blimp/client/core/contents/blimp_contents_impl.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M blimp/client/core/contents/blimp_contents_impl_unittest.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_manager.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_manager.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_manager_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_observer_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M blimp/client/core/contents/blimp_navigation_controller_impl.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M blimp/client/core/contents/blimp_navigation_controller_impl.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
shaktisahu
4 years, 4 months ago (2016-08-19 21:52:01 UTC) #2
nyquist
https://codereview.chromium.org/2258563003/diff/1/blimp/client/core/blimp_client_context_impl.cc File blimp/client/core/blimp_client_context_impl.cc (right): https://codereview.chromium.org/2258563003/diff/1/blimp/client/core/blimp_client_context_impl.cc#newcode67 blimp/client/core/blimp_client_context_impl.cc:67: Should you register the features here? https://codereview.chromium.org/2258563003/diff/1/blimp/client/core/contents/android/blimp_contents_factory.cc File blimp/client/core/contents/android/blimp_contents_factory.cc ...
4 years, 3 months ago (2016-08-24 20:49:11 UTC) #4
shaktisahu
Rebased.
4 years, 3 months ago (2016-08-24 22:14:27 UTC) #5
nyquist
lgtm
4 years, 3 months ago (2016-08-26 19:01:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258563003/60001
4 years, 3 months ago (2016-08-26 19:01:52 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-08-26 19:46:50 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:50:18 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f
Cr-Commit-Position: refs/heads/master@{#414786}

Powered by Google App Engine
This is Rietveld 408576698