Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: blimp/client/core/contents/blimp_contents_manager_unittest.cc

Issue 2258563003: Added features to BlimpClientContext and BlimpContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime_feature_move
Patch Set: Register features Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/blimp_contents_manager.h" 5 #include "blimp/client/core/contents/blimp_contents_manager.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "blimp/client/core/contents/blimp_contents_impl.h" 9 #include "blimp/client/core/contents/blimp_contents_impl.h"
10 #include "blimp/client/core/contents/tab_control_feature.h" 10 #include "blimp/client/core/contents/tab_control_feature.h"
(...skipping 19 matching lines...) Expand all
30 MOCK_METHOD1(CloseTab, void(int)); 30 MOCK_METHOD1(CloseTab, void(int));
31 31
32 private: 32 private:
33 DISALLOW_COPY_AND_ASSIGN(MockTabControlFeature); 33 DISALLOW_COPY_AND_ASSIGN(MockTabControlFeature);
34 }; 34 };
35 35
36 TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) { 36 TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) {
37 base::MessageLoop loop; 37 base::MessageLoop loop;
38 MockTabControlFeature tab_control_feature; 38 MockTabControlFeature tab_control_feature;
39 39
40 BlimpContentsManager blimp_contents_manager(&tab_control_feature); 40 BlimpContentsManager blimp_contents_manager(nullptr, nullptr,
41 &tab_control_feature);
41 42
42 EXPECT_CALL(tab_control_feature, CreateTab(_)).Times(1); 43 EXPECT_CALL(tab_control_feature, CreateTab(_)).Times(1);
43 std::unique_ptr<BlimpContentsImpl> blimp_contents = 44 std::unique_ptr<BlimpContentsImpl> blimp_contents =
44 blimp_contents_manager.CreateBlimpContents(); 45 blimp_contents_manager.CreateBlimpContents();
45 int id = blimp_contents->id(); 46 int id = blimp_contents->id();
46 BlimpContentsImpl* existing_contents = 47 BlimpContentsImpl* existing_contents =
47 blimp_contents_manager.GetBlimpContents(id); 48 blimp_contents_manager.GetBlimpContents(id);
48 EXPECT_EQ(blimp_contents.get(), existing_contents); 49 EXPECT_EQ(blimp_contents.get(), existing_contents);
49 } 50 }
50 51
51 TEST(BlimpContentsManagerUnittest, GetNonExistingBlimpContents) { 52 TEST(BlimpContentsManagerUnittest, GetNonExistingBlimpContents) {
52 MockTabControlFeature tab_control_feature; 53 MockTabControlFeature tab_control_feature;
53 54
54 BlimpContentsManager blimp_contents_manager(&tab_control_feature); 55 BlimpContentsManager blimp_contents_manager(nullptr, nullptr,
56 &tab_control_feature);
55 57
56 BlimpContentsImpl* existing_contents = 58 BlimpContentsImpl* existing_contents =
57 blimp_contents_manager.GetBlimpContents(kDummyTabId); 59 blimp_contents_manager.GetBlimpContents(kDummyTabId);
58 EXPECT_EQ(nullptr, existing_contents); 60 EXPECT_EQ(nullptr, existing_contents);
59 } 61 }
60 62
61 TEST(BlimpContentsManagerUnittest, GetDestroyedBlimpContents) { 63 TEST(BlimpContentsManagerUnittest, GetDestroyedBlimpContents) {
62 base::MessageLoop loop; 64 base::MessageLoop loop;
63 MockTabControlFeature tab_control_feature; 65 MockTabControlFeature tab_control_feature;
64 BlimpContentsManager blimp_contents_manager(&tab_control_feature); 66 BlimpContentsManager blimp_contents_manager(nullptr, nullptr,
67 &tab_control_feature);
65 int id; 68 int id;
66 69
67 EXPECT_CALL(tab_control_feature, CreateTab(_)).Times(1); 70 EXPECT_CALL(tab_control_feature, CreateTab(_)).Times(1);
68 std::unique_ptr<BlimpContentsImpl> blimp_contents = 71 std::unique_ptr<BlimpContentsImpl> blimp_contents =
69 blimp_contents_manager.CreateBlimpContents(); 72 blimp_contents_manager.CreateBlimpContents();
70 id = blimp_contents.get()->id(); 73 id = blimp_contents.get()->id();
71 BlimpContentsImpl* existing_contents = 74 BlimpContentsImpl* existing_contents =
72 blimp_contents_manager.GetBlimpContents(id); 75 blimp_contents_manager.GetBlimpContents(id);
73 EXPECT_EQ(blimp_contents.get(), existing_contents); 76 EXPECT_EQ(blimp_contents.get(), existing_contents);
74 77
75 EXPECT_CALL(tab_control_feature, CloseTab(id)).Times(1); 78 EXPECT_CALL(tab_control_feature, CloseTab(id)).Times(1);
76 blimp_contents.reset(); 79 blimp_contents.reset();
77 80
78 loop.RunUntilIdle(); 81 loop.RunUntilIdle();
79 EXPECT_EQ(nullptr, blimp_contents_manager.GetBlimpContents(id)); 82 EXPECT_EQ(nullptr, blimp_contents_manager.GetBlimpContents(id));
80 } 83 }
81 84
82 } // namespace 85 } // namespace
83 } // namespace client 86 } // namespace client
84 } // namespace blimp 87 } // namespace blimp
OLDNEW
« no previous file with comments | « blimp/client/core/contents/blimp_contents_manager.cc ('k') | blimp/client/core/contents/blimp_contents_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698