blimp/client/core/contents/blimp_contents_manager_unittest.cc - Issue 2258563003: Added features to BlimpClientContext and BlimpContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_manager_unittest.cc

Issue 2258563003: Added features to BlimpClientContext and BlimpContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime_feature_move

Patch Set: Register features Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/contents/blimp_contents_manager.cc ('k') | blimp/client/core/contents/blimp_contents_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_contents_manager_unittest.cc

diff --git a/blimp/client/core/contents/blimp_contents_manager_unittest.cc b/blimp/client/core/contents/blimp_contents_manager_unittest.cc

index f87040ee69d7bcd740cd3e9e5cca081e33527d44..0a8f1f805f3c0cf10149b066d70bc96af583b290 100644

--- a/blimp/client/core/contents/blimp_contents_manager_unittest.cc

+++ b/blimp/client/core/contents/blimp_contents_manager_unittest.cc

@@ -37,7 +37,8 @@ TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) {

base::MessageLoop loop;

MockTabControlFeature tab_control_feature;

- BlimpContentsManager blimp_contents_manager(&tab_control_feature);

+ BlimpContentsManager blimp_contents_manager(nullptr, nullptr,

+ &tab_control_feature);

EXPECT_CALL(tab_control_feature, CreateTab(_)).Times(1);

std::unique_ptr<BlimpContentsImpl> blimp_contents =

@@ -51,7 +52,8 @@ TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) {

TEST(BlimpContentsManagerUnittest, GetNonExistingBlimpContents) {

MockTabControlFeature tab_control_feature;

- BlimpContentsManager blimp_contents_manager(&tab_control_feature);

+ BlimpContentsManager blimp_contents_manager(nullptr, nullptr,

+ &tab_control_feature);

BlimpContentsImpl* existing_contents =

blimp_contents_manager.GetBlimpContents(kDummyTabId);

@@ -61,7 +63,8 @@ TEST(BlimpContentsManagerUnittest, GetNonExistingBlimpContents) {

TEST(BlimpContentsManagerUnittest, GetDestroyedBlimpContents) {

base::MessageLoop loop;

MockTabControlFeature tab_control_feature;

- BlimpContentsManager blimp_contents_manager(&tab_control_feature);

+ BlimpContentsManager blimp_contents_manager(nullptr, nullptr,

+ &tab_control_feature);

int id;

EXPECT_CALL(tab_control_feature, CreateTab(_)).Times(1);