Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: blimp/client/core/contents/blimp_contents_impl_unittest.cc

Issue 2258563003: Added features to BlimpClientContext and BlimpContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime_feature_move
Patch Set: Register features Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_impl_unittest.cc
diff --git a/blimp/client/core/contents/blimp_contents_impl_unittest.cc b/blimp/client/core/contents/blimp_contents_impl_unittest.cc
index 5ae6f818eafdf84f437f31e50575dad6739af172..dede75004e3a631ffa1e2bd0efde67cb257158a2 100644
--- a/blimp/client/core/contents/blimp_contents_impl_unittest.cc
+++ b/blimp/client/core/contents/blimp_contents_impl_unittest.cc
@@ -43,13 +43,11 @@ class MockTabControlFeature : public TabControlFeature {
TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) {
base::MessageLoop loop;
- BlimpContentsImpl blimp_contents(kDummyTabId, nullptr);
+ FakeNavigationFeature feature;
+ BlimpContentsImpl blimp_contents(kDummyTabId, nullptr, &feature, nullptr);
BlimpNavigationControllerImpl& navigation_controller =
blimp_contents.GetNavigationController();
- FakeNavigationFeature feature;
- feature.SetDelegate(1, &navigation_controller);
- navigation_controller.SetNavigationFeatureForTesting(&feature);
testing::StrictMock<MockBlimpContentsObserver> observer1(&blimp_contents);
testing::StrictMock<MockBlimpContentsObserver> observer2(&blimp_contents);
@@ -78,7 +76,8 @@ TEST(BlimpContentsImplTest, SetSizeAndScaleThroughTabControlFeature) {
MockTabControlFeature tab_control_feature;
base::MessageLoop loop;
- BlimpContentsImpl blimp_contents(kDummyTabId, &tab_control_feature);
+ BlimpContentsImpl blimp_contents(kDummyTabId, nullptr, nullptr,
+ &tab_control_feature);
EXPECT_CALL(tab_control_feature,
SetSizeAndScale(gfx::Size(width, height), dp_to_px)).Times(1);
« no previous file with comments | « blimp/client/core/contents/blimp_contents_impl.cc ('k') | blimp/client/core/contents/blimp_contents_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698