Add "learn more" links to SSL and SB interstitials

Add "learn more" links to SSL and SB interstitials

BUG=639166
Committed: https://crrev.com/911ba12253b14bfe874a321c57031f5ac534ce31
Cr-Commit-Position: refs/heads/master@{#414243}

[felt, 2016-08-20 05:40:36]

The CQ bit was checked by felt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 05:40:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[felt, 2016-08-20 05:40:53]

Description was changed from

==========
Add "learn more" links to SSL and SB interstitials

BUG=639166
==========

to

==========
Add "learn more" links to SSL and SB interstitials

BUG=639166
==========

[felt, 2016-08-20 05:40:54]

felt@chromium.org changed reviewers:
+ nparker@chromium.org

[felt, 2016-08-20 05:41:02]

nparker, ptal

[commit-bot: I haz the power, 2016-08-20 06:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 06:21:09]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[felt, 2016-08-22 06:10:45]

Whoops, tests are failing. Let me update the tests before you take a look.

[felt, 2016-08-23 16:05:26]

The CQ bit was checked by felt@chromium.org to run a CQ dry run

[felt, 2016-08-23 16:05:32]

Fixed the tests. PTAL?

[commit-bot: I haz the power, 2016-08-23 16:06:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 17:02:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 17:02:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nathan Parker, 2016-08-24 14:54:27]

lgtm

I'm assuming you'll have looked at the resulting interstitials (since I can't
see the end result)

https://codereview.chromium.org/2257173005/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/2257173005/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9092: -      Google Safe Browsing recently
detected phishing on <ph name="SITE">$1<ex>example.com</ex></ph>. <ph
name="BEGIN_LINK">&lt;a href="#" id="help-link"&gt;</ph>Phishing sites<ph
name="END_LINK">&lt;/a&gt;</ph> pretend to be other websites to trick you.
So this is removing the link to the transparency report, ya?  I think that's ok
(HC is better).. It's just hard to grok what the end result will be here, but
that's GRD files I guess

https://codereview.chromium.org/2257173005/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):

https://codereview.chromium.org/2257173005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:72: const char
kLearnMore[] = "https://support.google.com/chrome/answer/99020";
I wonder if there's a way to continue to verify this and other hard-coded links
aren't not broken.  I don't expect it to disappear, but who knows.

https://codereview.chromium.org/2257173005/diff/40001/components/security_int...
File components/security_interstitials_strings.grdp (right):

https://codereview.chromium.org/2257173005/diff/40001/components/security_int...
components/security_interstitials_strings.grdp:1: <?xml version="1.0"
encoding="utf-8"?>
Q: How is this different from ssl_errors_strings.grdp?

[felt, 2016-08-24 15:48:16]

https://codereview.chromium.org/2257173005/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/2257173005/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9092: -      Google Safe Browsing recently
detected phishing on <ph name="SITE">$1<ex>example.com</ex></ph>. <ph
name="BEGIN_LINK">&lt;a href="#" id="help-link"&gt;</ph>Phishing sites<ph
name="END_LINK">&lt;/a&gt;</ph> pretend to be other websites to trick you.
On 2016/08/24 14:54:27, Nathan Parker wrote:
> So this is removing the link to the transparency report, ya?  I think that's
ok
> (HC is better).. It's just hard to grok what the end result will be here, but
> that's GRD files I guess

The link to the TR stays in for all of them except phishing, where we don't give
useful per-domain information in the TR. I stuck in the generic TR link for
phishing because it felt weird to not have any link at all; now that there's a
"Learn more" link, I figured I'd take it out.

https://codereview.chromium.org/2257173005/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):

https://codereview.chromium.org/2257173005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:72: const char
kLearnMore[] = "https://support.google.com/chrome/answer/99020";
On 2016/08/24 14:54:27, Nathan Parker wrote:
> I wonder if there's a way to continue to verify this and other hard-coded
links
> aren't not broken.  I don't expect it to disappear, but who knows.

Yeah, that's a good point. I have no idea how to do this though, since our tests
shouldn't actually be generating network traffic. :/

https://codereview.chromium.org/2257173005/diff/40001/components/security_int...
File components/security_interstitials_strings.grdp (right):

https://codereview.chromium.org/2257173005/diff/40001/components/security_int...
components/security_interstitials_strings.grdp:1: <?xml version="1.0"
encoding="utf-8"?>
On 2016/08/24 14:54:27, Nathan Parker wrote:
> Q: How is this different from ssl_errors_strings.grdp?

That's a good question. I was wondering that too (why did past-me put these in
separate files?). The reason is because of how the components are split up. For
legacy reasons, the "details" strings for errors are stuffed into an SSLInfo in
the ssl_errors class and then passed in to the interstitial. And ssl_errors and
security_interstitials are in separate components. I think I'd like to come back
(in another CL) and revisit why the details strings are put through SSLInfo.

[felt, 2016-08-24 15:48:35]

On 2016/08/24 14:54:27, Nathan Parker wrote:
> lgtm
> 
> I'm assuming you'll have looked at the resulting interstitials (since I can't
> see the end result)

and yup, they look as expected

> 
>
https://codereview.chromium.org/2257173005/diff/40001/chrome/app/generated_re...
> File chrome/app/generated_resources.grd (left):
> 
>
https://codereview.chromium.org/2257173005/diff/40001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:9092: -      Google Safe Browsing recently
> detected phishing on <ph name="SITE">$1<ex>example.com</ex></ph>. <ph
> name="BEGIN_LINK">&lt;a href="#" id="help-link"&gt;</ph>Phishing sites<ph
> name="END_LINK">&lt;/a&gt;</ph> pretend to be other websites to trick you.
> So this is removing the link to the transparency report, ya?  I think that's
ok
> (HC is better).. It's just hard to grok what the end result will be here, but
> that's GRD files I guess
> 
>
https://codereview.chromium.org/2257173005/diff/40001/chrome/browser/safe_bro...
> File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):
> 
>
https://codereview.chromium.org/2257173005/diff/40001/chrome/browser/safe_bro...
> chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:72: const char
> kLearnMore[] = "https://support.google.com/chrome/answer/99020";
> I wonder if there's a way to continue to verify this and other hard-coded
links
> aren't not broken.  I don't expect it to disappear, but who knows.
> 
>
https://codereview.chromium.org/2257173005/diff/40001/components/security_int...
> File components/security_interstitials_strings.grdp (right):
> 
>
https://codereview.chromium.org/2257173005/diff/40001/components/security_int...
> components/security_interstitials_strings.grdp:1: <?xml version="1.0"
> encoding="utf-8"?>
> Q: How is this different from ssl_errors_strings.grdp?

[felt, 2016-08-24 22:50:38]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:51:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:30:05]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[felt, 2016-08-25 00:31:07]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:33:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 01:12:46]

Description was changed from

==========
Add "learn more" links to SSL and SB interstitials

BUG=639166
==========

to

==========
Add "learn more" links to SSL and SB interstitials

BUG=639166
==========

[commit-bot: I haz the power, 2016-08-25 01:12:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 01:15:06]

Description was changed from

==========
Add "learn more" links to SSL and SB interstitials

BUG=639166
==========

to

==========
Add "learn more" links to SSL and SB interstitials

BUG=639166

Committed: https://crrev.com/911ba12253b14bfe874a321c57031f5ac534ce31
Cr-Commit-Position: refs/heads/master@{#414243}
==========

[commit-bot: I haz the power, 2016-08-25 01:15:07]

Patchset 3 (id:??) landed as
https://crrev.com/911ba12253b14bfe874a321c57031f5ac534ce31
Cr-Commit-Position: refs/heads/master@{#414243}