Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1814)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 2257173005: Add "learn more" links to SSL and SB interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update browser tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
index 1b92c1e0d4ca5252bea38c4fabd24ae4dc91a756..63b1d373eb02422ca1eeee8147c8cbc347a4714e 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
@@ -504,7 +504,7 @@ class SafeBrowsingBlockingPageBrowserTest
EXPECT_EQ(HIDDEN, GetVisibility("opt-in-checkbox"));
EXPECT_EQ(HIDDEN, GetVisibility("proceed-link"));
EXPECT_TRUE(Click("details-button"));
- EXPECT_EQ(VISIBLE, GetVisibility("help-link"));
+ EXPECT_EQ(VISIBLE, GetVisibility("learn-more-link"));
EXPECT_EQ(VISIBLE, GetVisibility("proceed-link"));
EXPECT_TRUE(ClickAndWaitForDetach("primary-button"));
@@ -844,15 +844,17 @@ IN_PROC_BROWSER_TEST_P(SafeBrowsingBlockingPageBrowserTest,
IN_PROC_BROWSER_TEST_P(SafeBrowsingBlockingPageBrowserTest, LearnMore) {
SetupWarningAndNavigate();
- EXPECT_TRUE(ClickAndWaitForDetach("help-link"));
+ EXPECT_TRUE(ClickAndWaitForDetach("learn-more-link"));
AssertNoInterstitial(false); // Assert the interstitial is gone
// We are in the help page.
EXPECT_EQ(
- testing::get<0>(GetParam()) == SB_THREAT_TYPE_URL_PHISHING
- ? "/transparencyreport/safebrowsing/"
- : "/safebrowsing/diagnostic",
- browser()->tab_strip_model()->GetActiveWebContents()->GetURL().path());
+ GURL("https://support.google.com/chrome/answer/99020").GetWithEmptyPath(),
+ browser()
+ ->tab_strip_model()
+ ->GetActiveWebContents()
+ ->GetURL()
+ .GetWithEmptyPath());
}
IN_PROC_BROWSER_TEST_P(SafeBrowsingBlockingPageBrowserTest,

Powered by Google App Engine
This is Rietveld 408576698