Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5140)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 2257173005: Add "learn more" links to SSL and SB interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update browser tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index fe0ee0b2c496fc9d47d866be89cd519dc51161f2..10a45726b67e8948f5d9a5b99bff3a2c95bef948 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -68,11 +68,8 @@ const char kSbDiagnosticUrl[] =
"https://www.google.com/safebrowsing/diagnostic?site=%s&client=chromium";
#endif
-// URL for malware and phishing, V2.
-const char kLearnMoreMalwareUrlV2[] =
- "https://www.google.com/transparencyreport/safebrowsing/";
-const char kLearnMorePhishingUrlV2[] =
- "https://www.google.com/transparencyreport/safebrowsing/";
+// URL for the Help Center article on Safe Browsing warnings.
+const char kLearnMore[] = "https://support.google.com/chrome/answer/99020";
Nathan Parker 2016/08/24 14:54:27 I wonder if there's a way to continue to verify th
felt 2016/08/24 15:48:16 Yeah, that's a good point. I have no idea how to d
// After a safe browsing interstitial where the user opted-in to the report
// but clicked "proceed anyway", we delay the call to
@@ -253,9 +250,7 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& page_cmd) {
// User pressed "Learn more".
metrics_helper()->RecordUserInteraction(
security_interstitials::MetricsHelper::SHOW_LEARN_MORE);
- GURL learn_more_url(
- interstitial_reason_ == SB_REASON_PHISHING ?
- kLearnMorePhishingUrlV2 : kLearnMoreMalwareUrlV2);
+ GURL learn_more_url(kLearnMore);
learn_more_url = google_util::AppendGoogleLocaleParam(
learn_more_url, g_browser_process->GetApplicationLocale());
OpenURLParams params(learn_more_url,

Powered by Google App Engine
This is Rietveld 408576698