Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2257053002: Fix XHR stale comments (Closed)

Created:
4 years, 4 months ago by yhirano
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix XHR stale comments BUG=580068 R=tyoshino Committed: https://crrev.com/d23f5eeddd88e38f81af83a40e556c527dd6ef55 Cr-Commit-Position: refs/heads/master@{#412783}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +0 lines, -4 lines 1 comment Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
yhirano
4 years, 4 months ago (2016-08-18 07:26:42 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/2257053002/diff/1/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h (left): https://codereview.chromium.org/2257053002/diff/1/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h#oldcode229 third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h:229: // refcount on it to prevent it from destroyed. ...
4 years, 4 months ago (2016-08-18 07:44:36 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm as discussed offline
4 years, 4 months ago (2016-08-18 09:12:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257053002/1
4 years, 4 months ago (2016-08-18 09:15:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 10:05:34 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 10:08:21 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d23f5eeddd88e38f81af83a40e556c527dd6ef55
Cr-Commit-Position: refs/heads/master@{#412783}

Powered by Google App Engine
This is Rietveld 408576698