third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h - Issue 2257053002: Fix XHR stale comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

Issue 2257053002: Fix XHR stale comments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

index d8f6862c80855a7fb87f8679ecf2fbbf694a1444..a0df2539c8ea688507f768865535f55a826f8b00 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

@@ -223,10 +223,6 @@ private:

// Clears variables used only while the resource is being loaded.

void clearVariablesForLoading();

// Returns false iff reentry happened and a new load is started.

- //

- // This method may invoke V8 GC with m_loader unset. If you touch the

- // XMLHttpRequest instance after internalAbort() call, you must hold a

- // refcount on it to prevent it from destroyed.

tyoshino (SeeGerritForStatus) 2016/08/18 07:44:36 ScopedEventDispatchProtect is still needed?

bool internalAbort();

// Clears variables holding response header and body data.

void clearResponse();

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »