Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 2257053002: Fix XHR stale comments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
index 106d51f3d417c8aa6decafa22e34ce3222aa2781..41c0edcdf32afe2abb78461b697dbab069a8d114 100644
--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
@@ -1336,13 +1336,11 @@ void XMLHttpRequest::didFail(const ResourceError& error)
if (error.isCancellation()) {
handleDidCancel();
- // Now the XMLHttpRequest instance may be dead.
return;
}
if (error.isTimeout()) {
handleDidTimeout();
- // Now the XMLHttpRequest instance may be dead.
return;
}
@@ -1351,7 +1349,6 @@ void XMLHttpRequest::didFail(const ResourceError& error)
logConsoleError(getExecutionContext(), "XMLHttpRequest cannot load " + error.failingURL() + ". " + error.localizedDescription());
handleNetworkError();
- // Now the XMLHttpRequest instance may be dead.
}
void XMLHttpRequest::didFailRedirectCheck()
@@ -1360,7 +1357,6 @@ void XMLHttpRequest::didFailRedirectCheck()
ScopedEventDispatchProtect protect(&m_eventDispatchRecursionLevel);
handleNetworkError();
- // Now the XMLHttpRequest instance may be dead.
}
void XMLHttpRequest::didFinishLoading(unsigned long identifier, double)

Powered by Google App Engine
This is Rietveld 408576698