Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

Issue 2257053002: Fix XHR stale comments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005, 2006 Alexey Proskuryakov <ap@nypop.com> 3 * Copyright (C) 2005, 2006 Alexey Proskuryakov <ap@nypop.com>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * Copyright (C) 2012 Intel Corporation 5 * Copyright (C) 2012 Intel Corporation
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Lesser General Public 8 * modify it under the terms of the GNU Lesser General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 216
217 void trackProgress(long long dataLength); 217 void trackProgress(long long dataLength);
218 // Changes m_state and dispatches a readyStateChange event if new m_state 218 // Changes m_state and dispatches a readyStateChange event if new m_state
219 // value is different from last one. 219 // value is different from last one.
220 void changeState(State newState); 220 void changeState(State newState);
221 void dispatchReadyStateChangeEvent(); 221 void dispatchReadyStateChangeEvent();
222 222
223 // Clears variables used only while the resource is being loaded. 223 // Clears variables used only while the resource is being loaded.
224 void clearVariablesForLoading(); 224 void clearVariablesForLoading();
225 // Returns false iff reentry happened and a new load is started. 225 // Returns false iff reentry happened and a new load is started.
226 //
227 // This method may invoke V8 GC with m_loader unset. If you touch the
228 // XMLHttpRequest instance after internalAbort() call, you must hold a
229 // refcount on it to prevent it from destroyed.
tyoshino (SeeGerritForStatus) 2016/08/18 07:44:36 ScopedEventDispatchProtect is still needed?
230 bool internalAbort(); 226 bool internalAbort();
231 // Clears variables holding response header and body data. 227 // Clears variables holding response header and body data.
232 void clearResponse(); 228 void clearResponse();
233 void clearRequest(); 229 void clearRequest();
234 230
235 void createRequest(PassRefPtr<EncodedFormData>, ExceptionState&); 231 void createRequest(PassRefPtr<EncodedFormData>, ExceptionState&);
236 232
237 // Dispatches a response ProgressEvent. 233 // Dispatches a response ProgressEvent.
238 void dispatchProgressEvent(const AtomicString&, long long, long long); 234 void dispatchProgressEvent(const AtomicString&, long long, long long);
239 // Dispatches a response ProgressEvent using values sampled from 235 // Dispatches a response ProgressEvent using values sampled from
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 // option. 314 // option.
319 bool m_downloadingToFile; 315 bool m_downloadingToFile;
320 bool m_responseTextOverflow; 316 bool m_responseTextOverflow;
321 }; 317 };
322 318
323 std::ostream& operator<<(std::ostream&, const XMLHttpRequest*); 319 std::ostream& operator<<(std::ostream&, const XMLHttpRequest*);
324 320
325 } // namespace blink 321 } // namespace blink
326 322
327 #endif // XMLHttpRequest_h 323 #endif // XMLHttpRequest_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698