Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2255883002: Pass ClientSocketHandle ownership around in unique_ptr. (Closed)

Created:
4 years, 4 months ago by Bence
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass ClientSocketHandle ownership around in unique_ptr. Change HttpBasicStream and HttpBasicState constructors to take a unique_ptr<ClientSocketHandle> instead of a raw ClientSocketHandle*, to better express that they are taking ownership of that object. Committed: https://crrev.com/3faa41e40504893e1ccdd2aeb1cdcbc62da79ec6 Cr-Commit-Position: refs/heads/master@{#412822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M net/http/http_basic_state.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_basic_state.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/http/http_basic_state_unittest.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M net/http/http_basic_stream.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/http/http_basic_stream.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Bence
Ryan: PTAL.
4 years, 4 months ago (2016-08-18 12:15:34 UTC) #6
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-18 13:46:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255883002/1
4 years, 4 months ago (2016-08-18 14:12:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 14:16:38 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 14:18:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3faa41e40504893e1ccdd2aeb1cdcbc62da79ec6
Cr-Commit-Position: refs/heads/master@{#412822}

Powered by Google App Engine
This is Rietveld 408576698