net/http/http_basic_state.cc - Issue 2255883002: Pass ClientSocketHandle ownership around in unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_basic_state.cc

Issue 2255883002: Pass ClientSocketHandle ownership around in unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_basic_state.cc

diff --git a/net/http/http_basic_state.cc b/net/http/http_basic_state.cc

index 2e5ca06ebe85959f3944c91a107fa7f12af1a8fc..ceadb5761eba00ff916a53972d5303e6f4030f96 100644

--- a/net/http/http_basic_state.cc

+++ b/net/http/http_basic_state.cc

@@ -17,9 +17,10 @@

namespace net {

-HttpBasicState::HttpBasicState(ClientSocketHandle* connection, bool using_proxy)

+HttpBasicState::HttpBasicState(std::unique_ptr<ClientSocketHandle> connection,

+ bool using_proxy)

: read_buf_(new GrowableIOBuffer()),

- connection_(connection),

+ connection_(std::move(connection)),

using_proxy_(using_proxy),

request_info_(NULL) {}

« no previous file with comments | « net/http/http_basic_state.h ('k') | net/http/http_basic_state_unittest.cc » ('j') | no next file with comments »