net/http/http_basic_stream.h - Issue 2255883002: Pass ClientSocketHandle ownership around in unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_basic_stream.h

Issue 2255883002: Pass ClientSocketHandle ownership around in unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_basic_stream.h

diff --git a/net/http/http_basic_stream.h b/net/http/http_basic_stream.h

index cb3ea2fd517dcdf9549a858562a6dc0197873995..53fad144112bf61368b6c5c0ccc2c555d354f018 100644

--- a/net/http/http_basic_stream.h

+++ b/net/http/http_basic_stream.h

@@ -11,6 +11,7 @@

#include <stdint.h>

+#include <memory>

#include <string>

#include "base/macros.h"

@@ -32,7 +33,8 @@ class NET_EXPORT_PRIVATE HttpBasicStream : public HttpStream {

public:

// Constructs a new HttpBasicStream. InitializeStream must be called to

// initialize it correctly.

- HttpBasicStream(ClientSocketHandle* connection, bool using_proxy);

+ HttpBasicStream(std::unique_ptr<ClientSocketHandle> connection,

+ bool using_proxy);

~HttpBasicStream() override;

// HttpStream methods:

« no previous file with comments | « net/http/http_basic_state_unittest.cc ('k') | net/http/http_basic_stream.cc » ('j') | no next file with comments »