net/http/http_network_transaction_unittest.cc - Issue 2255883002: Pass ClientSocketHandle ownership around in unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2255883002: Pass ClientSocketHandle ownership around in unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction_unittest.cc

diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc

index 60f4ae035cd611752a4a85ae802729fe883ff857..0bb806c1526a4f7a670a71eee705ee2a35beba3c 100644

--- a/net/http/http_network_transaction_unittest.cc

+++ b/net/http/http_network_transaction_unittest.cc

@@ -14296,7 +14296,7 @@ class FakeWebSocketBasicHandshakeStream : public WebSocketHandshakeStreamBase {

FakeWebSocketBasicHandshakeStream(

std::unique_ptr<ClientSocketHandle> connection,

bool using_proxy)

- : state_(connection.release(), using_proxy) {}

+ : state_(std::move(connection), using_proxy) {}

// Fake implementation of HttpStreamBase methods.

// This ends up being quite "real" because this object has to really send data

« no previous file with comments | « net/http/http_basic_stream.cc ('k') | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »