IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289
Committed: https://crrev.com/4238c66083f3a0043d237f4dcdd60a16b536e252
Cr-Commit-Position: refs/heads/master@{#412703}

[jsbell, 2016-08-17 18:07:55]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 18:08:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 18:50:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 18:50:25]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-08-17 19:11:54]

cmumford@ - please take a look?

[cmumford, 2016-08-17 20:26:29]

lgtm % question.

BTW do you think it would be possible to make BlobDataHandle a movable type so
that we could get rid of the unique_ptr?

https://codereview.chromium.org/2255853003/diff/1/content/browser/indexed_db/...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/2255853003/diff/1/content/browser/indexed_db/...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:721: params,
base::Passed(std::move(handles))));
If I'm reading bind_helpers.h correctly this could just be:

   base::Passed(&handles);

[jsbell, 2016-08-17 23:15:38]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-08-17 23:15:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/2255853003/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-08-17 23:16:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-08-17 23:16:19]

On 2016/08/17 20:26:29, cmumford wrote:
> BTW do you think it would be possible to make BlobDataHandle a movable type so
> that we could get rid of the unique_ptr?

Probably - file a bug against dmurph@ ?

https://codereview.chromium.org/2255853003/diff/1/content/browser/indexed_db/...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/2255853003/diff/1/content/browser/indexed_db/...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:721: params,
base::Passed(std::move(handles))));
On 2016/08/17 20:26:29, cmumford wrote:
> If I'm reading bind_helpers.h correctly this could just be:
> 
>    base::Passed(&handles);

Done.

[Avi (use Gerrit), 2016-08-17 23:17:05]

BTW, removal of ScopedVector is http://crbug.com/554289 .

[jsbell, 2016-08-17 23:20:49]

Description was changed from

==========
IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
==========

to

==========
IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289
==========

[commit-bot: I haz the power, 2016-08-18 00:24:07]

Description was changed from

==========
IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289
==========

to

==========
IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289
==========

[commit-bot: I haz the power, 2016-08-18 00:24:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 00:29:26]

Description was changed from

==========
IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289
==========

to

==========
IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289

Committed: https://crrev.com/4238c66083f3a0043d237f4dcdd60a16b536e252
Cr-Commit-Position: refs/heads/master@{#412703}
==========

[commit-bot: I haz the power, 2016-08-18 00:29:27]

Patchset 2 (id:??) landed as
https://crrev.com/4238c66083f3a0043d237f4dcdd60a16b536e252
Cr-Commit-Position: refs/heads/master@{#412703}