content/browser/indexed_db/indexed_db_dispatcher_host.h - Issue 2255853003: IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_dispatcher_host.h

Issue 2255853003: IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_database_unittest.cc ('k') | content/browser/indexed_db/indexed_db_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_dispatcher_host.h

diff --git a/content/browser/indexed_db/indexed_db_dispatcher_host.h b/content/browser/indexed_db/indexed_db_dispatcher_host.h

index 4ff5bd486d53bd7b5523c23805c634740456b588..8f3bda65718b5d983abe6026afd170f236c50333 100644

--- a/content/browser/indexed_db/indexed_db_dispatcher_host.h

+++ b/content/browser/indexed_db/indexed_db_dispatcher_host.h

@@ -187,7 +187,7 @@ class IndexedDBDispatcherHost : public BrowserMessageFilter {

// before posting to the IDB TaskRunner for the rest of the job.

void OnPutWrapper(const IndexedDBHostMsg_DatabasePut_Params& params);

void OnPut(const IndexedDBHostMsg_DatabasePut_Params& params,

- std::vector<storage::BlobDataHandle*> handles);

+ std::vector<std::unique_ptr<storage::BlobDataHandle>> handles);

void OnSetIndexKeys(

const IndexedDBHostMsg_DatabaseSetIndexKeys_Params& params);

void OnSetIndexesReady(int32_t ipc_database_id,

@@ -288,8 +288,9 @@ class IndexedDBDispatcherHost : public BrowserMessageFilter {

const IndexedDBHostMsg_FactoryDeleteDatabase_Params& p);

void OnAckReceivedBlobs(const std::vector<std::string>& uuids);

- void OnPutHelper(const IndexedDBHostMsg_DatabasePut_Params& params,

- std::vector<storage::BlobDataHandle*> handles);

+ void OnPutHelper(

+ const IndexedDBHostMsg_DatabasePut_Params& params,

+ std::vector<std::unique_ptr<storage::BlobDataHandle>> handles);

void ResetDispatcherHosts();

void DropBlobData(const std::string& uuid);