content/browser/indexed_db/indexed_db_index_writer.h - Issue 2255853003: IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_index_writer.h

Issue 2255853003: IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_fake_backing_store.cc ('k') | content/browser/indexed_db/indexed_db_index_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_index_writer.h

diff --git a/content/browser/indexed_db/indexed_db_index_writer.h b/content/browser/indexed_db/indexed_db_index_writer.h

index 41b7de31a94303c0eba2bf3627f28fd7134e56ec..f4cae95b53236d34ba8bdff8d8fc523c27a613b2 100644

--- a/content/browser/indexed_db/indexed_db_index_writer.h

+++ b/content/browser/indexed_db/indexed_db_index_writer.h

@@ -8,10 +8,10 @@

#include <stdint.h>

#include <map>

+#include <memory>

#include <vector>

#include "base/macros.h"

-#include "base/memory/scoped_vector.h"

#include "content/browser/indexed_db/indexed_db_backing_store.h"

#include "content/browser/indexed_db/indexed_db_database.h"

#include "content/browser/indexed_db/indexed_db_metadata.h"

@@ -70,7 +70,7 @@ bool MakeIndexWriters(

const IndexedDBKey& primary_key,

bool key_was_generated,

const std::vector<IndexedDBDatabase::IndexKeys>& index_keys,

- ScopedVector<IndexWriter>* index_writers,

+ std::vector<std::unique_ptr<IndexWriter>>* index_writers,

base::string16* error_message,

bool* completed) WARN_UNUSED_RESULT;