content/browser/indexed_db/indexed_db_database_unittest.cc - Issue 2255853003: IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_database_unittest.cc

Issue 2255853003: IndexedDB: ScopedVector<T> -> vector<unique_ptr<T>> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/indexed_db/indexed_db_database_unittest.cc

diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc

index f9a0183ee577078e112a039c7704362a9741d4d0..35662e454f22dd90a9761b78a34e9af75ab312cf 100644

--- a/content/browser/indexed_db/indexed_db_database_unittest.cc

+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc

@@ -397,7 +397,7 @@ TEST_F(IndexedDBDatabaseOperationTest, CreatePutDelete) {

// Put is asynchronous

IndexedDBValue value("value1", std::vector<IndexedDBBlobInfo>());

- ScopedVector<storage::BlobDataHandle> handles;

+ std::vector<std::unique_ptr<storage::BlobDataHandle>> handles;

std::unique_ptr<IndexedDBKey> key(base::MakeUnique<IndexedDBKey>("key"));

std::vector<IndexedDBDatabase::IndexKeys> index_keys;

scoped_refptr<MockIndexedDBCallbacks> request(

« no previous file with comments | « content/browser/indexed_db/indexed_db_database.cc ('k') | content/browser/indexed_db/indexed_db_dispatcher_host.h » ('j') | no next file with comments »