Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2255623003: Enable trust anchor constraints for the built-in Cast roots. (Closed)

Created:
4 years, 4 months ago by eroman
Modified:
4 years, 4 months ago
Reviewers:
sheretov, ryanchung
CC:
chromium-reviews, sheretov+watch_chromium.org, dougsteed+watch_chromium.org, vadimgo+watch_chromium.org, ryanchung+watch_chromium.org, mattm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable trust anchor constraints for the built-in Cast roots. Cast Root CA * Now has its pathlen:2 constraint (once again) enforced Cast CRL Root CA * Now has its pathlen:1 constraint (one again) enforced BUG=635200 Committed: https://crrev.com/46826c6ee250b07ad5d0ef2ab7c9ea3281b40108 Cr-Commit-Position: refs/heads/master@{#413015}

Patch Set 1 #

Patch Set 2 : fix some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+850 lines, -34 lines) Patch
M components/cast_certificate/cast_cert_validator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/cast_certificate/cast_cert_validator_unittest.cc View 1 18 chunks +142 lines, -27 lines 0 comments Download
M components/cast_certificate/cast_crl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/cast_certificate/cast_crl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/test/data/cast_certificate/certificates/expired_root.pem View 1 chunk +310 lines, -0 lines 0 comments Download
A components/test/data/cast_certificate/certificates/violates_root_pathlen_constraint.pem View 1 1 chunk +393 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
eroman
The (convoluted) mapping from Certificate --> Anchor Constraints tries to follow RFC 5937's description, with ...
4 years, 4 months ago (2016-08-17 02:40:24 UTC) #4
ryanchung
lgtm
4 years, 4 months ago (2016-08-18 21:30:26 UTC) #7
sheretov
lgtm lgtm
4 years, 4 months ago (2016-08-18 21:58:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255623003/20001
4 years, 4 months ago (2016-08-18 23:30:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 01:44:29 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 01:49:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46826c6ee250b07ad5d0ef2ab7c9ea3281b40108
Cr-Commit-Position: refs/heads/master@{#413015}

Powered by Google App Engine
This is Rietveld 408576698