Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: components/cast_certificate/cast_crl.cc

Issue 2255623003: Enable trust anchor constraints for the built-in Cast roots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix some comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cast_certificate/cast_crl.cc
diff --git a/components/cast_certificate/cast_crl.cc b/components/cast_certificate/cast_crl.cc
index e9233952d6a943d511cc38fcb57638699f1f6915..256623c867e751b005ef4498265656aedda9e2ba 100644
--- a/components/cast_certificate/cast_crl.cc
+++ b/components/cast_certificate/cast_crl.cc
@@ -67,10 +67,9 @@ class CastCRLTrustStore {
kCastCRLRootCaDer, sizeof(kCastCRLRootCaDer),
net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE, {});
CHECK(cert);
- // TODO(crbug.com/635200): Support anchor constraints, and initialize the
- // anchor using constraints from the self-signed certificate.
+ // Enforce pathlen constraints and policies defined on the root certificate.
scoped_refptr<net::TrustAnchor> anchor =
- net::TrustAnchor::CreateFromCertificateNoConstraints(std::move(cert));
+ net::TrustAnchor::CreateFromCertificateWithConstraints(std::move(cert));
CHECK(anchor);
store_.AddTrustAnchor(std::move(anchor));
}
« no previous file with comments | « components/cast_certificate/cast_cert_validator_unittest.cc ('k') | components/cast_certificate/cast_crl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698