Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: components/cast_certificate/cast_cert_validator.cc

Issue 2255623003: Enable trust anchor constraints for the built-in Cast roots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix some comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cast_certificate/cast_cert_validator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cast_certificate/cast_cert_validator.cc
diff --git a/components/cast_certificate/cast_cert_validator.cc b/components/cast_certificate/cast_cert_validator.cc
index 3e9bb222a2663bc9fb0fc8a33098d4826faaa013..65a3154dcf4dd65594b7f3f1fa1b48edf30bd087 100644
--- a/components/cast_certificate/cast_cert_validator.cc
+++ b/components/cast_certificate/cast_cert_validator.cc
@@ -72,10 +72,9 @@ class CastTrustStore {
data, N, net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE,
{});
CHECK(cert);
- // TODO(crbug.com/635200): Support anchor constraints, and initialize the
- // anchor using constraints from the self-signed certificate.
+ // Enforce pathlen constraints and policies defined on the root certificate.
scoped_refptr<net::TrustAnchor> anchor =
- net::TrustAnchor::CreateFromCertificateNoConstraints(std::move(cert));
+ net::TrustAnchor::CreateFromCertificateWithConstraints(std::move(cert));
store_.AddTrustAnchor(std::move(anchor));
}
« no previous file with comments | « no previous file | components/cast_certificate/cast_cert_validator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698