components/cast_certificate/cast_crl_unittest.cc - Issue 2255623003: Enable trust anchor constraints for the built-in Cast roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cast_certificate/cast_crl_unittest.cc

Issue 2255623003: Enable trust anchor constraints for the built-in Cast roots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix some comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cast_certificate/cast_crl.cc ('k') | components/test/data/cast_certificate/certificates/expired_root.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cast_certificate/cast_crl_unittest.cc

diff --git a/components/cast_certificate/cast_crl_unittest.cc b/components/cast_certificate/cast_crl_unittest.cc

index 5d845fe1d1e273107e4e953262e67e44a42739ed..196f450c3bbcb36f559b9e8bdf6e099347b86afa 100644

--- a/components/cast_certificate/cast_crl_unittest.cc

+++ b/components/cast_certificate/cast_crl_unittest.cc

@@ -24,7 +24,7 @@ std::unique_ptr<net::TrustStore> CreateTrustStoreFromFile(

net::ParsedCertificate::CreateFromCertificateCopy(trusted_root, {}));

EXPECT_TRUE(cert);

scoped_refptr<net::TrustAnchor> anchor =

- net::TrustAnchor::CreateFromCertificateNoConstraints(std::move(cert));

+ net::TrustAnchor::CreateFromCertificateWithConstraints(std::move(cert));

trust_store->AddTrustAnchor(std::move(anchor));

}

return trust_store;

« no previous file with comments | « components/cast_certificate/cast_crl.cc ('k') | components/test/data/cast_certificate/certificates/expired_root.pem » ('j') | no next file with comments »