Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2254813002: Remove SignInSource from ShowSigninCommand. (Closed)

Created:
4 years, 4 months ago by bzanotti
Modified:
4 years, 4 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@signin_source
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SignInSource from ShowSigninCommand. Also remove it altogether as it isn't used anymore. BUG=612908 Committed: https://crrev.com/4ee2fb2289b93dc501f5f93b292daf4532761443 Cr-Commit-Position: refs/heads/master@{#413458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -70 lines) Patch
M ios/chrome/browser/signin/constants.h View 1 chunk +0 lines, -34 lines 0 comments Download
M ios/chrome/browser/ui/commands/show_signin_command.h View 3 chunks +1 line, -15 lines 0 comments Download
M ios/chrome/browser/ui/commands/show_signin_command.mm View 2 chunks +2 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
bzanotti
Please take a look. Note that I won't submit this until SignInSource has been removed ...
4 years, 4 months ago (2016-08-18 09:51:35 UTC) #2
marq (ping after 24h)
lgtm
4 years, 4 months ago (2016-08-18 16:41:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254813002/1
4 years, 4 months ago (2016-08-22 16:00:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ee2fb2289b93dc501f5f93b292daf4532761443 Cr-Commit-Position: refs/heads/master@{#413458}
4 years, 4 months ago (2016-08-22 17:03:34 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:03:39 UTC) #8
Message was sent while issue was closed.
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698