Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: ios/chrome/browser/ui/commands/show_signin_command.mm

Issue 2254813002: Remove SignInSource from ShowSigninCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@signin_source
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/commands/show_signin_command.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/commands/show_signin_command.mm
diff --git a/ios/chrome/browser/ui/commands/show_signin_command.mm b/ios/chrome/browser/ui/commands/show_signin_command.mm
index ca152fe368ef849ef93a563bbb0bca4b405d9e95..7b254de0da661a52147f0516469eba5ae1d62bef 100644
--- a/ios/chrome/browser/ui/commands/show_signin_command.mm
+++ b/ios/chrome/browser/ui/commands/show_signin_command.mm
@@ -13,7 +13,6 @@
}
@synthesize operation = _operation;
-@synthesize signInSource = _signInSource;
@synthesize signInAccessPoint = _signInAccessPoint;
- (instancetype)initWithTag:(NSInteger)tag {
@@ -22,31 +21,13 @@
}
- (instancetype)initWithOperation:(AuthenticationOperation)operation
- signInSource:(SignInSource)signInSource
+ signInAccessPoint:(signin_metrics::AccessPoint)signInAccessPoint
callback:
(ShowSigninCommandCompletionCallback)callback {
if ((self = [super initWithTag:IDC_SHOW_SIGNIN_IOS])) {
_operation = operation;
- _signInSource = signInSource;
- _callback.reset(callback, base::scoped_policy::RETAIN);
- }
- return self;
-}
-
-- (instancetype)initWithOperation:(AuthenticationOperation)operation
- signInSource:(SignInSource)signInSource {
- return
- [self initWithOperation:operation signInSource:signInSource callback:nil];
-}
-
-- (instancetype)initWithOperation:(AuthenticationOperation)operation
- signInAccessPoint:(signin_metrics::AccessPoint)signInAccessPoint
- callback:
- (ShowSigninCommandCompletionCallback)callback {
- if ((self = [self initWithOperation:operation
- signInSource:SIGN_IN_SOURCE_OTHER
- callback:callback])) {
_signInAccessPoint = signInAccessPoint;
+ _callback.reset(callback, base::scoped_policy::RETAIN);
}
return self;
}
« no previous file with comments | « ios/chrome/browser/ui/commands/show_signin_command.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698