Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2253113002: Add signin_metrics::AccessPoint to ShowSigninCommand. (Closed)

Created:
4 years, 4 months ago by bzanotti
Modified:
4 years, 4 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add signin_metrics::AccessPoint to ShowSigninCommand. BUG=612908 Committed: https://crrev.com/eb93d3f967a28b4c27fe32c2d7cdd44297716cf7 Cr-Commit-Position: refs/heads/master@{#412872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M ios/chrome/browser/ui/commands/show_signin_command.h View 3 chunks +15 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/show_signin_command.mm View 2 chunks +21 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
bzanotti
Please take a look.
4 years, 4 months ago (2016-08-18 09:50:59 UTC) #2
marq (ping after 24h)
lgtm
4 years, 4 months ago (2016-08-18 16:40:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253113002/1
4 years, 4 months ago (2016-08-18 16:45:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 17:29:58 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:33:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb93d3f967a28b4c27fe32c2d7cdd44297716cf7
Cr-Commit-Position: refs/heads/master@{#412872}

Powered by Google App Engine
This is Rietveld 408576698